Skip to content

Conversation

Chriztiaan
Copy link
Contributor

@Chriztiaan Chriztiaan commented Mar 12, 2024

Description

This updates the Expo dependency to v50 (and dependencies that were bumped alongside it) and adds a github job to the test workflow that tests the iOS build (cache included for cocoapods and build) but doesn't run the tests against a simulator.

Added an iOS command to tests/scripts/test.js that can be used in the iOS test job if someone can figure out how to get a simulator to work in github actions.

Expo 50 changelog here: https://expo.dev/changelog/2024/01-18-sdk-50
Important changes for apps moving to Expo 50:

  • Android SDK 34, AGP 8, and Java 17. If you build your project locally, you will need to install JDK 17. Learn more.
  • Android minimum supported version bumped to Android 6 (API 23).
  • iOS minimum deployment target bumped to 13.4.
  • Expo CLI and React Native now require Node 18+.

Introduced cocoapods test worfklow cache

Kicking off another build

Wider cache path for ios build

Added xcode cache action

Never skip cocaopods install

Use react-native depedency from workspace in test workflow

Trigger build to verify cache works

Removed unused simulator cache
Copy link
Collaborator

@stevensJourney stevensJourney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Awesome work on adding the iOS compilation test

@Chriztiaan Chriztiaan marked this pull request as ready for review March 13, 2024 07:06
@Chriztiaan Chriztiaan merged commit 3068f2e into main Mar 13, 2024
@Chriztiaan Chriztiaan deleted the expo-50-upgrade branch March 13, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants