[Web] Flush at the end of each writeLock #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevensJourney
previously approved these changes
Nov 5, 2024
- sqlite_async@0.11.0 - drift_sqlite_async@0.2.0-alpha.4
stevensJourney
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IndexedDB-based filesystem used by default for web flushes any changed pages in the background. This can cause data loss: Data that appears to be written (transaction returned successfully) have not actually been persisted to disk.
This now does an explicit
flush()on the filesystem after every write transaction or statement. This can have significant performance overhead for some usage patterns, so this can be disabled on a per-transaction level.The
flush: falseoption is a niche use-case, so only exposed on theWebSqliteConnectionabstract class, and not the more generalSqliteConnection.See an example of using the
flushoption here: powersync-ja/powersync.dart#208