Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dry run - 2nd proposal #3112

Closed
wants to merge 29 commits into from
Closed

Dry run - 2nd proposal #3112

wants to merge 29 commits into from

Conversation

olperr1
Copy link
Member

@olperr1 olperr1 commented Jul 31, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

Fixes #3001

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

⚠️ TODO

Other information:

TODO:

  • Launch a full dry-run if an UnsupportedDryRunException is caught from an IIDM API method
    • in NetworkModificationList, but also in "standard" NetworkModifications
    • with this method, custom IIDM implementation maintainers will have a way to "refuse" to execute a local dry run for certain methods (if a regular implementation is to hard to achieve). The concerned NetworkModifications' dry-runs will be slower, but they won't crash
  • Check generated reports
  • Fix the TODO in AbstractNetworkModification
  • Fix existing unit tests
  • Javadoc
  • Improve test coverage
  • Support dry-run for network element removal NetworkModifications
  • Migration guide
  • Documentation

olperr1 and others added 29 commits June 10, 2024 11:38
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
# Conflicts:
#	iidm/iidm-modification/src/main/java/com/powsybl/iidm/modification/AbstractDisconnection.java
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
…+ add the missing ones

Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
…y-run mechanism in apply methods

Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
…icationList

Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
@annetill
Copy link
Member

Rework with #3123 and #3127

@annetill annetill closed this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dry runs for network modifications
3 participants