Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix packaging of powsybl-math-native #1

Merged
merged 1 commit into from
Jun 27, 2019
Merged

Fix packaging of powsybl-math-native #1

merged 1 commit into from
Jun 27, 2019

Conversation

mathbagu
Copy link

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest
N/A

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This PR generates artefacts required by sonatype. It uses maven to generate and sign artefact instead of generate them via cmake.

What is the current behavior? (You can also link to an open issue here)
Publishing artefact is manual and doesn't fit with sonatype requirements

What is the new behavior (if this is a feature change)?
Publishing artefact is almost automatic and fit with sonatype requirements.

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

(if any of the questions/checkboxes don't apply, please delete them entirely)

- Fix some typos in README.md
- Fix pom.xml to generate every needed artefact to fit sonatype requirements
- Fix CMakeLists.txt to change the build directory to work with the new pom.xml
- Fix C++ source code to fit modern usage

Signed-off-by: Mathieu BAGUE <mathieu.bague@rte-france.com>
@mathbagu mathbagu requested a review from geofjamg June 26, 2019 10:54
@mathbagu mathbagu mentioned this pull request Jun 26, 2019
@geofjamg geofjamg merged commit c2cfa63 into master Jun 27, 2019
@geofjamg geofjamg deleted the fix-packaging branch June 27, 2019 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants