Improve logging, reporting and LF results for components without generators #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeandemanged
changed the title
|
Kudos, SonarCloud Quality Gate passed! |
Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
jeandemanged
force-pushed
the
dead_components
branch
from
a29c812 to
4fb4121
Compare
|
# Conflicts: # src/main/java/com/powsybl/openloadflow/network/LfNetwork.java
jeandemanged
changed the title
caioluke
approved these changes
Apr 29, 2024
7 tasks
jeandemanged
commented
May 7, 2024
| @@ -580,6 +597,21 @@ public void fix(boolean minImpedance, double lowImpedanceThreshold) { | |||
| } | |||
|
|
|||
| private void validateBuses(LoadFlowModel loadFlowModel, ReportNode reportNode) { | |||
| // DC or AC, if no generator, network is dead | |||
There was a problem hiding this comment.
we might want to add an option to allow computing islands without generators in DC
|
geofjamg
reviewed
May 14, 2024
There was a problem hiding this comment.
@jeandemanged ok for me to merge it as it is but:
- maybe in the future we might have some users feeback to calculate DC components even without any generator. In that case we will add a parameter to allow it.
- for our needs we will probably soon enrich components calculation criteria with additional checks like if slack distribution is on generator we need at least generator participating, if slack distribution is on loads we need at least one load etc.
geofjamg
approved these changes
May 14, 2024
jeandemanged
commented
May 16, 2024
Comment on lines
+267
to
+274
| public static ReportNode createLfNetworkReportNode(ReportNode reportNode, ReportNode lfNetworkReportNode, int networkNumCc, int networkNumSc) { | ||
| ReportNode newReportNode = reportNode.newReportNode() | ||
| .withMessageTemplate("lfNetwork", "Network CC${networkNumCc} SC${networkNumSc}") | ||
| .withUntypedValue(NETWORK_NUM_CC, networkNumCc) | ||
| .withUntypedValue(NETWORK_NUM_SC, networkNumSc) | ||
| .add(); | ||
| newReportNode.include(lfNetworkReportNode); | ||
| return newReportNode; |
There was a problem hiding this comment.
this will need to be revisited at next powsybl-core bump because of powsybl/powsybl-core#3007
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Feature
What is the current behavior?
Synchronous Components (islands) without any generator connected are causing many ERROR logs to be raised, and many report entries created which are just noise.
Hundreds of errors are logged & reported on real case large networks when OLF configured to solve all components which is quite inconvenient, and not really an error.
What is the new behavior (if this is a feature change)?
Network post-loading validation now:
Only relevant logs & reports are now produced.
For islands without any generator, only one log & one report entry is produced reporting the total number of islands where no calculation will be made.
With new LoadFlowResult API (see powsybl/powsybl-core#2767) and #918 we now are able to report new NO_CALCULATION status for "dead" islands without any generator.
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
n/a
What changes might users need to make in their application due to this PR? (migration steps)
n/a
Other information:
n/a