enable back preventive factors after sensi ends in 2P #1079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phiedw
reviewed
Jul 5, 2024
MartinBelthle
force-pushed
the
fix-2P--factors-issue
branch
from
1b30481
to
02c8d76
Compare
Signed-off-by: belthlemar <martin.belthle@rte-france.com>
MartinBelthle
force-pushed
the
fix-2P--factors-issue
branch
from
02c8d76
to
9159e99
Compare
pet-mit
added
bug
It's actually quite difficult to create such a test case on a 12node network, since it requires the MIP giving different results throughout the iterations, so I guess we should just keep the case that revealed the problem in our sensitive test data. |
pet-mit
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
In 2nd+ MIP iterations in 2P optimization, we had 0 flow on all preventive cnecs.
This caused too-optimistic decisions (0 flow means lot of margin) except when considering loop-flows where we'd have huge loop-flows penalties (0 flow but 1000MW of commercial flow means 1000MW of loop-flows) .
We did so because we disabled the preventive factors to speed-up sensi calculations on curative states without re-enabling it after all calculations were over.
What is the new behavior (if this is a feature change)?
We re-enable the factors after the sensi calculations and therefore do not have this problem.
Does this PR introduce a breaking change or deprecate an API?
Other information:
Cucumber test are running with this branch to see how many real cases were impacted.