Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shadow maps are missing in the glTFSample updated to Cauldron v1.4.5 #31

Closed
ppenenko opened this issue Jul 8, 2023 · 3 comments
Closed

Shadow maps are missing in the glTFSample updated to Cauldron v1.4.5 #31

ppenenko opened this issue Jul 8, 2023 · 3 comments
Assignees
@ppenenko
Labels
glTF Demo

Comments

@ppenenko
Copy link
Owner

ppenenko commented Jul 8, 2023

In my unmerged PR GPUOpen-LibrariesAndSDKs/glTFSample#6, I updated glTFSample from Cauldron v1.4.1 to Cauldron v1.4.5, without any Metashade-specific changes. Shadow maps are missing in that version. PIX shows that GltfDepthPass fails to draw anything into the depth render target (all pixels remain at the depth value of 1.0).
@ppenenko ppenenko mentioned this issue Jul 8, 2023
Open
@ppenenko
Copy link
Owner Author

ppenenko commented Jul 8, 2023

Prerequisite for #32

@ppenenko
Copy link
Owner Author

Both DX and VK are affected.

@ppenenko ppenenko self-assigned this Sep 8, 2023
ppenenko added a commit to ppenenko/Cauldron that referenced this issue Sep 8, 2023
@ppenenko
ppenenko/metashade#31: fixed the incorrectly inverted depth test in t…
a7a456c 
…he DX12 depth pass
ppenenko added a commit to ppenenko/Cauldron that referenced this issue Sep 8, 2023
@ppenenko
ppenenko/metashade#31: fixed the incorrectly inverted depth test in t…
b1bd514 
…he VK depth pass
@ppenenko
Copy link
Owner Author

ppenenko commented Sep 8, 2023

Fixed by GPUOpen-LibrariesAndSDKs/Cauldron#39

ppenenko added a commit to ppenenko/glTFSample that referenced this issue Sep 9, 2023
@ppenenko
Bumped Cauldron submodule with a fix for ppenenko/metashade#31
bffd948
@ppenenko ppenenko closed this as completed Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ppenenko ppenenko

Labels
glTF Demo
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ppenenko