Allow specifying queue name & scope of calculation in queue processor #227
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The end goal of this pull request is to be able to split queue processing of beatmaps into two parts: one that populates difficulty attributes exclusively, and one that populates scoring attributes only.
As per usage instructions:
So you'd potentially have two instances of the processor running:
correspondingly. The
queue-name
param feels a little redundant maybe and could be replaced by an implicit hardcoded mapping, but this felt better?Notably, when the processor is ran without arguments, the defaults are such that it falls back to the current mode of operations with no change in behaviour (everything from
osu-queue:beatmap
is processed).I did test this semi-manually on a local environment by pushing items to the queue manually via
redis-cli
. To make use of the params added here the sending end will have to be adjusted, but I am not sure that is something that I have access to at present.