Further refactor/rewrite ModelBackedDrawable #2466
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt #2, since there were regressions relating to the placeholder.
Important changes:
CreatePlaceholder()
method. It is null by default, notCreateDrawable(null)
.ReplaceDrawable()
has been split intoApplyHideTransforms()
andApplyShowTransforms()
.CreateDelayedLoadWrapper()
now handles recreation of content internally, removing the need for code such as https://github.com/ppy/osu/blob/master/osu.Game/Beatmaps/Drawables/UpdateableBeatmapBackgroundSprite.cs#L39 in the case of using an unload wrapper.