Split Container into a generic and a non-generic part #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplification of the code has surprisingly powerful performance and convenience implications. IContainer is no longer needed, and common container methods / properties can now be accessed without virtual dispatch. Further, due to the simplified casting, it is now possible to flatten the DrawNode hierarchy of generic containers, neat! Lastly, due to the avoidance of IContainer some members can now have non-public visibility, such as InternalChildren et al. This allows making containers which manage their own children and disallow adding / removing from outside.
This improves performance since it seems like the runtime isn't smart enough to properly optimize a nested enumerator.
Since it does not allow adding children from outside, it's pointless to allow instantiation.
Also updates XML docs
They are re-exposed in Container via new
…ntainer-split # Conflicts: # osu.Framework/Graphics/Containers/Container.cs
…ntainer-split # Conflicts: # osu.Framework/osu.Framework.csproj
peppy
approved these changes
Jul 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplification of the code has surprisingly powerful performance and convenience implications.
IContaineris no longer needed, and common container methods / properties can now be accessed without virtual dispatch. Further, due to the simplified casting, it is now possible to flatten theDrawNodetree of generic containers; neat! Lastly, due to the avoidance ofIContainer, some members can now have non-public visibility, such asInternalChildrenet al.. This allows making containers which manage their own children and disallow adding / removing from outside.