Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wiki search text box shouldn't have yellow border color when unfocused #10238

Closed
Joehuu opened this issue May 23, 2023 · 3 comments
Closed

Wiki search text box shouldn't have yellow border color when unfocused #10238

Joehuu opened this issue May 23, 2023 · 3 comments
Labels
area:wiki good first issue A good place to start contributing to this project without going too deep. waiting-on-design

Comments

@Joehuu
Copy link
Member

Joehuu commented May 23, 2023

I keep thinking that it's focused and type something but nothing is happening:
XW4R3DQmUC

I would expect the same behavior as the text box in beatmap listing:
x4nNzFgOG0
@Joehuu Joehuu changed the title Wiki search text box shouldn't have yellow border color if unfocused Wiki search text box shouldn't have yellow border color when unfocused May 23, 2023
@notbakaneko
Copy link
Collaborator

I think it makes sense to remove the outline or at least make it look less "highlighted" when not focused @arflyte

@peppy
Copy link
Member

peppy commented Oct 13, 2023 •
edited
Loading

Agree with removing when not focused. Bonus points if the style matches between the two instances (can still be yellow but more glowy like beatmap listing i guess?)

@cl8n cl8n added the good first issue A good place to start contributing to this project without going too deep. label Feb 6, 2024
@danielmyren danielmyren mentioned this issue Mar 30, 2024
Merged
@frenzibyte
Copy link
Member

Resolved in #11132

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:wiki good first issue A good place to start contributing to this project without going too deep. waiting-on-design
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@peppy @notbakaneko @cl8n @frenzibyte @Joehuu