Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scope to users endpoints #4798

Closed
Aergwyn opened this issue Aug 17, 2019 · 6 comments
Closed

Add scope to users endpoints #4798

Aergwyn opened this issue Aug 17, 2019 · 6 comments
Assignees
Labels
Milestone

Comments

@Aergwyn
Copy link
Member

Aergwyn commented Aug 17, 2019

Please add a scope to the api/v2/users/{user}/ endpoints to make them accessible.

@EVAST9919
Copy link

What case exactly do you mean?

@Aergwyn
Copy link
Member Author

Aergwyn commented Aug 17, 2019

Using any of the user endpoints results in an invalid scope error.
As far as I know there are only two scopes at the moment (identify and friends.read) thus making those endpoints inaccessible.

@cl8n
Copy link
Member

cl8n commented Aug 17, 2019

this should be almost identical to the identify implementation and pretty easy to do, if any new contributors want to try it

@peppy peppy added the type:api label Aug 22, 2019
@peppy peppy added this to the Candidate Issues milestone Aug 22, 2019
@nekodex
Copy link
Collaborator

nekodex commented Sep 11, 2019

To echo my comment from #4815:

Currently there's privileged information being returned by the API (e.g. account moderation info/metadata inside /users/xxx responses for users within the moderation group/etc) that we don't want third-party clients to get by default when granting basic "user read" permissions.

So we're gonna move out all the privileged info into separate permission group(s) first before we open up endpoints that could expose that data (so that for example, moderators don't accidentally leak privileged info to third-parties without realising).

@peppy peppy modified the milestones: Candidate Issues, January 2020 Dec 12, 2019
@peppy
Copy link
Member

peppy commented Dec 12, 2019

Would be good to get some eyes on this before january if time is available.

@nanaya
Copy link
Collaborator

nanaya commented Mar 11, 2020

Added in #5700.

@nanaya nanaya closed this as completed Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants