Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jaye's One Key Event tournament articles #11606

Merged
merged 12 commits into from
Aug 3, 2024
Merged

Conversation

Albionthegreat
Copy link
Contributor

@Albionthegreat Albionthegreat commented Jun 19, 2024

Self-check

This PR is not a JOKE

Copy link

Someone else has edited same files as you did. Please check their changes in case they conflict with yours:

Copy link
Contributor

@Laurakko Laurakko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but some mistakes, included in review

wiki/Tournaments/JOKE/1/en.md Outdated Show resolved Hide resolved
wiki/Tournaments/JOKE/1KWC_2024/en.md Outdated Show resolved Hide resolved
wiki/Tournaments/JOKE/1KWC_2024/en.md Outdated Show resolved Hide resolved
wiki/Tournaments/JOKE/1KWC_2024/en.md Outdated Show resolved Hide resolved
wiki/Tournaments/JOKE/1KWC_2024/en.md Outdated Show resolved Hide resolved
wiki/Tournaments/JOKE/2/en.md Outdated Show resolved Hide resolved
wiki/Tournaments/JOKE/3/en.md Outdated Show resolved Hide resolved
Copy link
Contributor

@Laurakko Laurakko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oop forgot to change to suggestions

wiki/Tournaments/JOKE/1/en.md Outdated Show resolved Hide resolved
wiki/Tournaments/JOKE/1KWC_2024/en.md Outdated Show resolved Hide resolved
wiki/Tournaments/JOKE/1KWC_2024/en.md Outdated Show resolved Hide resolved
wiki/Tournaments/JOKE/1KWC_2024/en.md Outdated Show resolved Hide resolved
wiki/Tournaments/JOKE/1KWC_2024/en.md Outdated Show resolved Hide resolved
wiki/Tournaments/JOKE/2/en.md Outdated Show resolved Hide resolved
wiki/Tournaments/JOKE/3/en.md Outdated Show resolved Hide resolved
Co-authored-by: Laura V. <163941367+Laurakko@users.noreply.github.com>
Copy link
Contributor

@0x84f 0x84f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skimmed over

wiki/Tournaments/JOKE/3/en.md Outdated Show resolved Hide resolved
wiki/Tournaments/JOKE/1/en.md Outdated Show resolved Hide resolved
Co-authored-by: 0x84f <24534022+0x84f@users.noreply.github.com>
Copy link

Your translation may be missing new information from corresponding English articles. Please update your translation according to the merged changes:

Copy link
Contributor

@TicClick TicClick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me
if your PRs are left behind, don't hesitate to bring it up in #osu-wiki

@TicClick TicClick enabled auto-merge August 3, 2024 19:49
@TicClick TicClick merged commit 350c024 into ppy:master Aug 3, 2024
2 checks passed
@Albionthegreat Albionthegreat deleted the JOKE branch August 6, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants