Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove end slashes from redirect links #1926

Merged
merged 1 commit into from
Jan 6, 2019
Merged

Remove end slashes from redirect links #1926

merged 1 commit into from
Jan 6, 2019

Conversation

Joehuu
Copy link
Member

@Joehuu Joehuu commented Dec 25, 2018

No description provided.

Copy link
Contributor

@sr229 sr229 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sr229
Copy link
Contributor

sr229 commented Dec 27, 2018

On a side note, would this break in osu-web side? CC from anyone in osu-web if this would break anything or fix?

@TPGPL TPGPL added the update label Dec 27, 2018
@Joehuu
Copy link
Member Author

Joehuu commented Jan 6, 2019

Don't think it'll mess up with anything. The other links without anchor links do not have end slashes and it works.

@cl8n
Copy link
Member

cl8n commented Jan 6, 2019

it won't, all is good 👍

@Repflez Repflez merged commit d787384 into ppy:master Jan 6, 2019
@Joehuu Joehuu deleted the end-slash-redirects branch January 8, 2019 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants