singer -> artist #1931
Merged
singer -> artist #1931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
people besides singers can be featured and this wording is bad
Joehuu
approved these changes
Dec 29, 2018
cl8n
approved these changes
Dec 29, 2018
Okorin
approved these changes
Dec 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
people besides singers can be featured and this particular word choice is bad and can lead to needless inconsistency: which would be being made to standardize if it's featuring a singer, not being made to standardize if it's featuring a different type of artist.
i.e. ft. violin player, featuring composer dude, etc
so this word switch fixes that