Fix disable mouse buttons setting not showing default indicator when using keybind

[Joehuu]

The problem is that ConfigManager's Set changes the default value to the changed one.

https://github.com/ppy/osu-framework/blob/1a0a270c9c933fdd469398b2db4086bef56b7101/osu.Framework/Configuration/ConfigManager.cs#L108-L125

Before	After

[peppy]

This looks like a pretty large gotcha with the Set method...

@smoogipoo any issues with fixing this on the framework side? something like this https://github.com/ppy/osu-framework/compare/master...peppy:fix-config-manager-set-default?expand=1

[frenzibyte]

Yep, was gonna suggest separating setting default value of setting to another method (SetWithDefault) but yours sounds much better.

[smoogipoo]

I'm fine with a framework change, but it setting the default should be the... default. Most usages of Set are expecting to set defaults (e.g. sensitivity: min: 0.1, default/value: 1, max: 6).
So something like Set(..., bool isDefaultValue = true) would be fine imo.

I'm also not really against the change in this PR if we disagree on that.

[peppy]

I was planning on just having the first Set call ever set the default (since the general pattern is to always call Set in InitialiseDefaults in order to use a specific configuration enum). Is that too haphazard?

[smoogipoo]

Hmmm... It feels weird in terms of the overrides accepting min/max values, no? I'm actually not sure if it should even be public in the first place, and that this PR is what we want in the end.

[peppy]

Can agree to making the Set methods protected, for sure.