Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map status doesn't update #19976

Closed
just7nz opened this issue Aug 26, 2022 · 13 comments · Fixed by #20013
Closed

Map status doesn't update #19976

just7nz opened this issue Aug 26, 2022 · 13 comments · Fixed by #20013
Assignees
Labels
realm deals with local realm database

Comments

@just7nz
Copy link

just7nz commented Aug 26, 2022

Type

Game behaviour

Bug description

A map that was previously loved and then got ranked can't be updated in Lazer's song select, deleting and redownloading the map doesn't change anything

Screenshots or videos

2022-08-26.15-13-39.mp4

Version

2022.821.0

Logs

performance-audio.log
performance-draw.log
performance-input.log
performance-update.log
runtime.log
updater.log
database.log
legacy-ipc.log
network.log
performance.log

@peppy
Copy link
Member

peppy commented Aug 26, 2022

Could you please zip and attach your client.realm file?

@just7nz
Copy link
Author

just7nz commented Aug 26, 2022

client.zip

@peppy peppy self-assigned this Aug 29, 2022
@peppy peppy added the realm deals with local realm database label Aug 29, 2022
peppy added a commit to peppy/osu that referenced this issue Aug 29, 2022
This covers the rare case where metadata may have changed server-side but not
the beatmap itself.

Tested with the provided user database to resolve the issue.

Closes ppy#19976.
@kafibu
Copy link

kafibu commented Sep 1, 2022

I still have this issue and the "Update" button doesn't appear for me

Screenshot

osu_2022-09-01_16-40-11

Version

2022-901.0

Logs

performance.log
runtime.log
updater.log
database.log
network.log

client.realm

client.zip

@peppy
Copy link
Member

peppy commented Sep 2, 2022

@kafibu What you're saying is that you should have an update button because the beatmap should be "ranked" now, not qualified?

The system of tracking online beatmap states was only added to the game on the 23rd July, but the beatmap in question was ranked in June. For this reason it probably wasn't correctly being tracked by the new metadata tracking. Also I'm not 100% sure if server-side we correctly trigger the update event when a map switches from qualified to ranked. I'll take a look into that.

@peppy
Copy link
Member

peppy commented Sep 2, 2022

Please check your client again. I forced a server-side metadata update so it should also have updated on your client now.

@kafibu
Copy link

kafibu commented Sep 2, 2022

It still doesn't work and redownloading doesn't fix it

@peppy
Copy link
Member

peppy commented Sep 2, 2022

Can you confirm that the issue is that the map still shows "qualified" to you?

I tested with your database and it looks fine. Are you not logged in or something? You will only get metadata updates if you're logged in.

@kafibu
Copy link

kafibu commented Sep 2, 2022

I'm logged in

@kafibu
Copy link

kafibu commented Sep 3, 2022

Ok i fix it by going into the editor changing the map to force the update button appear. This is where option to manually reprocess beatmap like in stable would be nice

@peppy
Copy link
Member

peppy commented Sep 3, 2022

The whole point is that that should not be required.

@sineplusx
Copy link

sineplusx commented Sep 6, 2022

I'd like to reopen this issue because I still experience it in version 2022.902.1 on Windows.

Like previously described by @kafibu, when a beatmap changes from qualified to ranked state, the song select screen still shows the qualified state. Deleting and redownloading the map does not change this. The update button does not appear for me, unless I change beatmap parameters in the editor. Once present, the update button does work and lazer puts the beatmap into the correct state once it finishes the download.

I downloaded a dozen of qualified maps to test this, in my example I'm using https://osu.ppy.sh/beatmapsets/1054988

osu_2022-09-06_22-20-34
osu_2022-09-06_22-20-31

Screen Recordings

bug1.mp4
bug2.mp4
bug3.mp4

Logs and Realm
runtime.log
database.log
network.log

client.realm.zip

@peppy
Copy link
Member

peppy commented Sep 7, 2022

A server side fix for this will be deployed sometimes in the near future. It's already merged but not yet deployed.

@Non-Binary-Programmer
Copy link

I don't know if this fix has been deployed yet, but assuming it has, the issue has regressed. The map GimmexGimme has been transitioned from pending to loved status, but still displays as pending in my lazer client, persisting through redownloads. Notably, when viewing the beatmap webpage through lazer, it properly displays as loved, and the beatmap leaderboard does not display in the lazer client.

Screen.Recording.2023-01-27.at.9.25.50.PM.mov

Logs + realm:
database.log
input.log
network.log
performance-draw.log
performance-update.log
performance.log
runtime.log
client.realm.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
realm deals with local realm database
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants