Spinners can show a huge negative SPM number

[smoogipoo]

Discussed in #21210

^{Originally posted by Gabixel November 12, 2022}
I initially saw this long succession of zeros in the editor, but it was so random that I couldn't get a screenshot and reproduce it.
It might refer to #10455, but since it also happens with replays I guess it has to be handled differently.

Today, randomly looking at one of my replays, I spammed the right arrow at the end of the map timeline (where there was a spinner), and it would seem to give the same result that I saw in the editor a while ago (wait for the gif):

By moving the timeline back slightly you can also pause without being transported to the result screen. Consequently, you can inspect the large number:

I am not a great expert here, but checking in the C# documentation, this number seems to look a lot like the minimum value of a double, at least for the initial digits:

I couldn't reproduce it with AutoPlay, even after trying the various mod combinations I used in my replay. So it may be a case-specific to how I rotated the spinner.

In case you want to test and reproduce,

• here's the replay (as usual, rename it to .osr)
• here's the map

I can imagine that the easiest solution is to limit the minimum value to 0. I doubt that anyone can get negative spins per minute

(Version is 2022.1101.0-lazer)

[tematikkp]

Weird, it also shows 477+ SPM which isn't capped.

[smoogipoo]

@tematikkp that's intentional.

[tematikkp]

why? because of the new scoring system? (well, it's used to be not capped back in 2008)

[smoogipoo]

Correct. For now only the maximum score is capped so even if you spin at 700 RPM you can only achieve the same score as if you spun at a constant 477.

Unsure if this will change in the future, especially as some glaring problems with spinners have yet to be addressed (that they're cheeseable).

[KantoChampion]

Are the 0's denoting the number of spins per minute? From what I can see, it's reflecting the spins per minute, displaying the end of the negative value shown in the screenshot. And since SPM isn't capped, It looks like your spins surpass any logical limit. Can anyone realistically achieve a SPM RPM passed a certain point? And to avoid this issue, wouldn't it be wise to cap it? (even to a value of 10000RPM etc.)

[KantoChampion]

@tematikkp Implemented an attempted fix. Can you pull this branch and try reproducing the issue? Can you also add any useful logs if you encounter the same problem?

https://github.com/KantoChampion/osu.git