Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osu!lazer not loading rulesets (Android) #6507

Closed
X4X5 opened this issue Oct 14, 2019 · 16 comments · Fixed by #6510 or #14442
Closed

osu!lazer not loading rulesets (Android) #6507

X4X5 opened this issue Oct 14, 2019 · 16 comments · Fixed by #6510 or #14442
Labels
platform/android priority:3 Nice to have, at some point

Comments

@X4X5
Copy link

X4X5 commented Oct 14, 2019

Describe the bug: I don't really know how serious this is, mainly because Lazer ran fine with few lag spikes, but whenever I open Lazer, I keep getting a notification saying, "Could not load rulesets from directory."

Screenshots or videos showing encountered issue:
Screenshot_20191013-204820

osu!lazer version: 2019.1011.0

Logs:
runtime.log

@X4X5 X4X5 changed the title osu!lazer not loading rulesets osu!lazer not loading rulesets (Android) Oct 14, 2019
@bdach
Copy link
Collaborator

bdach commented Oct 14, 2019

This is due to Environment.CurrentDirectory pointing to the filesystem root / on Android devices, and the OS quite rightly complaining about not having permissions to access it, here:

string[] files = Directory.GetFiles(Environment.CurrentDirectory, $"{ruleset_library_prefix}.*.dll");

It's not fatal, but we should probably consider not even trying to load from fs on mobile/if permissions are missing.

@X4X5
Copy link
Author

X4X5 commented Oct 14, 2019

Meaning there are permission I have to manually give Lazer access to?

@bdach
Copy link
Collaborator

bdach commented Oct 14, 2019

No, this is not a permission-granting issue, we shouldn't even go looking there on Android. / is not going to be accessible on any unrooted device.

@bdach
Copy link
Collaborator

bdach commented Oct 25, 2019

Seems to not be completely fixed, as I've seen a log on 2019.1021.0 where this persisted (see #6605)

@bdach bdach reopened this Oct 25, 2019
@dragonGod97677
Copy link

dragonGod97677 commented Oct 25, 2019

/ root of android is still accessible on lollipop to marshmallow version (and i think, nought too..), and but still, lazer should point access direct to it's data folder,

private location /data/data/sh.ppy.osulazer/

or

public {INTERNAL_OR_EXTERNAL_MEMORY}/Android/data/sh.ppy.osulazer/

not the root "/" to find such file cause on newer versions of android, access to root folder is impossible

@X4X5
Copy link
Author

X4X5 commented Oct 25, 2019

If it's a root folder, don't you have to root the device? And my phone isn't like one of the nicer phones; it's a Samsung Galaxy J3 V, so I wonder if just the type of phone it is has something to do with the issue, idk.

@dragonGod97677
Copy link

Rooting not necessarily required, it's maybe lazer side problem, not the phone it self. Just wait X4X5 until they fixed it

@X4X5
Copy link
Author

X4X5 commented Oct 25, 2019

Got it

@peppy peppy modified the milestones: Candidate Issues, November 2019 Oct 28, 2019
@smoogipoo
Copy link
Contributor

A fix was attempted in #6510 but it seems like it didn't work, since this is still occurring. It's likely that the reason is Environment.CurrentDirectory being reset in https://github.com/ppy/osu-framework/blob/94bfa3473f15824180ea4fcc3f3a3e716c0fc735/osu.Framework/Platform/GameHost.cs#L495

@sentry-io
Copy link

sentry-io bot commented Nov 20, 2019

Sentry issue: OSU-LAZER-38P

@X4X5
Copy link
Author

X4X5 commented Nov 20, 2019

So is there anyway that this can go about getting fixed?

@dragonGod97677
Copy link

Same as #7282

@bdach
Copy link
Collaborator

bdach commented Dec 19, 2019

@dragonGod97677 As far as I'm aware this error shouldn't be fatal or cause hangs, so it's not a duplicate of the issue you mention.

@dragonGod97677
Copy link

dragonGod97677 commented Dec 19, 2019 via email

@peppy peppy modified the milestones: Candidate Issues, Backlog Feb 12, 2020
@peppy peppy added priority:3 Nice to have, at some point and removed low priority labels Feb 12, 2020
@peppy peppy removed this from the Backlog milestone Feb 17, 2020
@Flutterish
Copy link
Contributor

This also happens on Mii 9, it does find the rulesets but cannot load them.
IMG_20201002_102821

@bdach
Copy link
Collaborator

bdach commented Oct 2, 2020

@Flutterish that is not the exact same error and as such does not fall within the scope of this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform/android priority:3 Nice to have, at some point
Projects
None yet
6 participants