Rename "Aim Assist" to "Magnetised" to better suit the mod's behaviour #17588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoogipoo
previously approved these changes
Apr 1, 2022
peppy
commented
Apr 1, 2022
| public override double ScoreMultiplier => 1; | ||
| public override Type[] IncompatibleMods => new[] { typeof(OsuModAutopilot), typeof(OsuModWiggle), typeof(OsuModTransform), typeof(ModAutoplay), typeof(OsuModRelax) }; | ||
|
|
||
| private IFrameStableClock gameplayClock; | ||
|
|
||
| [SettingSource("Assist strength", "How much this mod will assist you.", 0)] | ||
| [SettingSource("Attraction strength", "How strong the pull is.", 0)] | ||
| public BindableFloat AssistStrength { get; } = new BindableFloat(0.5f) |
There was a problem hiding this comment.
I didn't rename the property here to avoid breaking compatibility, but then realised the mod name is changing so that's a non issue. Think we should rename this to AttractionStrength while here, or not important?
smoogipoo
approved these changes
Apr 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As proposed in #17375.