Refactor scoring to remove async methods / simplify #20011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppy
requested changes
Aug 29, 2022
| /// <returns>The given <paramref name="scores"/> ordered by decreasing total score.</returns> | ||
| public async Task<ScoreInfo[]> OrderByTotalScoreAsync(ScoreInfo[] scores, CancellationToken cancellationToken = default) | ||
| public IEnumerable<ScoreInfo> OrderByTotalScore(IEnumerable<ScoreInfo> scores) |
There was a problem hiding this comment.
public IEnumerable<ScoreInfo> OrderByTotalScore(IEnumerable<ScoreInfo> scores) =>
scores.OrderByDescending(s => GetTotalScore(s))
.ThenBy(s => s.OnlineID);
peppy
approved these changes
Aug 29, 2022
|
Fyi I tested this in combination with ppy/osu-web#9223 and it works as expected. |
This was referenced Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SoloScoreInfoto allow full score calculation withoutDifficultyCalculator#19519This applies the remaining cleanup mentioned in #20008
MaximumStatistics).Note that since ppy/osu-web#9223 hasn't been merged yet, scores will appear as:
