Add osu! hit object dim #20572
Merged
Add osu! hit object dim #20572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stable would dim objects when they can't be hit (ie. the "miss" window is not active yet). This was never implemented in lazer, and causes quite large visual differences. No one has mentioned this yet, but it will definitely be one of those missing pieces which makes lazer feel different to stable.
|
As far as I can tell from code alone, it should also be applied to slider bodies, but
|
|
Ah that's unfortunate. I tested with sliders before using the |
|
I've split the miss window out into a constant, since it's pretty constant. Can confirm that sliders are now working again. |
|
Hmm, it's still not quite correct, because it's doubly applied to head circles on sliders: |
|
Well caught.
Can you test again? |
smoogipoo
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stable would dim objects when they can't be hit (ie. the "miss" window is not active yet). This was never implemented in lazer, and causes quite large visual differences.
No one has mentioned this yet, but it will definitely be one of those missing pieces which makes lazer feel different to stable.
Before:
osu.2022-10-04.at.08.34.23.mp4
After:
osu.2022-10-04.at.08.30.14.mp4