Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFix new detections in rider 2018.1 #2444
Conversation
peppy
added some commits
Apr 23, 2018
| @@ -53,6 +57,9 @@ public override void Add(HitObjectMask drawable) | ||
| public override bool Remove(HitObjectMask drawable) | ||
| { | ||
| // Rider 2018.1 requires this (roslyn analyser issue?) | ||
| Debug.Assert(drawable != null); |
This comment has been minimized.
This comment has been minimized.
smoogipoo
Apr 23, 2018
Contributor
Have you reported this to them? Seems like a pretty weird scenario...
This comment has been minimized.
This comment has been minimized.
peppy
Apr 23, 2018
Member
Plan on doing so. No combination of [NotNull] helps, either. Could be roslyn, not r#.
peppy
dismissed
smoogipoo’s
stale review
via
0014a95
Apr 23, 2018
peppy
added
the
code quality
label
Apr 23, 2018
peppy
added this to the April 2018 milestone
Apr 23, 2018
peppy
merged commit 2bd2fac
into
ppy:master
Apr 23, 2018
1 check passed
continuous-integration/appveyor/pr
AppVeyor build succeeded
Details
peppy
deleted the
peppy:misc-fixes
branch
Jun 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
peppy commentedApr 23, 2018
No description provided.