New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new detections in rider 2018.1 #2444

Merged
merged 4 commits into from Apr 23, 2018

Conversation

2 participants
@peppy
Member

peppy commented Apr 23, 2018

No description provided.

@@ -53,6 +57,9 @@ public override void Add(HitObjectMask drawable)
public override bool Remove(HitObjectMask drawable)
{
// Rider 2018.1 requires this (roslyn analyser issue?)
Debug.Assert(drawable != null);

This comment has been minimized.

@smoogipoo

smoogipoo Apr 23, 2018

Contributor

Have you reported this to them? Seems like a pretty weird scenario...

This comment has been minimized.

@peppy

peppy Apr 23, 2018

Member

Plan on doing so. No combination of [NotNull] helps, either. Could be roslyn, not r#.

@peppy peppy added the code quality label Apr 23, 2018

@peppy peppy added this to the April 2018 milestone Apr 23, 2018

@peppy peppy merged commit 2bd2fac into ppy:master Apr 23, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@peppy peppy deleted the peppy:misc-fixes branch Jun 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment