Fix new detections in rider 2018.1 #2444
Merged
Conversation
| @@ -53,6 +57,9 @@ public override void Add(HitObjectMask drawable) | |||
|
|
|||
| public override bool Remove(HitObjectMask drawable) | |||
| { | |||
| // Rider 2018.1 requires this (roslyn analyser issue?) | |||
| Debug.Assert(drawable != null); | |||
smoogipoo
Apr 23, 2018
Contributor
Have you reported this to them? Seems like a pretty weird scenario...
Have you reported this to them? Seems like a pretty weird scenario...
peppy
Apr 23, 2018
Author
Member
Plan on doing so. No combination of [NotNull] helps, either. Could be roslyn, not r#.
Plan on doing so. No combination of [NotNull] helps, either. Could be roslyn, not r#.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
No description provided.