Adjust mania scoring to be more in line with ScoreV2 + 85% acc / 15% combo #25945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdach
reviewed
Dec 20, 2023
Comment on lines
+370
to
+371
| 850000 * comboProportion | ||
| + 150000 * Math.Pow(score.Accuracy, 2 + 2 * score.Accuracy) |
There was a problem hiding this comment.
Given that this is in ConvertFromLegacyTotalScore(), should we be bumping score version again to upgrade previously-imported stable scores to the new proportions?
(Key point, I am not talking about lazer scores here; emphasis on legacy total score.)
|
Also, to be doubly clear: if we merge this in its current state, we will have to reopen #24238. Moving extra score for PERFECTs to bonus was supposed to make SSes achievable on scores that do not have all PERFECTs. Is this OK? |
|
Time and game mechanics are apparently a circle. I'm honestly not sure which is better, but we're going to merge this and find out (hopefully sooner rather than later) which voice is stronger. |
bdach
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See feedback in #25810 (comment) + https://discord.com/channels/188630481301012481/1186947899796500590
15% combo is the lowest I'm willing to go.
This will need the same sort of considerations as #25887 (comment), eventually...