Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom message in the case of a invalid beatmap_hash #27783

Merged

Conversation

64ArthurAraujo
Copy link
Contributor

Closes #27781, very small PR just adding a case for the "invalid beatmap_hash" exception.Message. Now it will show
a better message: "A new version of this beatmapset is available please update. Your score will not be submitted."

@SupDos
Copy link
Contributor

SupDos commented Apr 3, 2024

You're missing a comma: available, please

Personally I think a better message for this would be
This beatmap doesn't match the official version, please update or re-download this beatmap.\n\n{whatWillHappen}

@bdach
Copy link
Collaborator

bdach commented Apr 3, 2024

This message doesn't necessarily mean that an update to the beatmap is available. It might also mean that the beatmap has been modified (i.e. by changing it in stable and importing from there). Or it might mean that the beatmap was intentionally maliciously modified. Or it might mean corruption. And so on and so forth.

I'm not sure how to feel about this change in that light.

@64ArthurAraujo
Copy link
Contributor Author

64ArthurAraujo commented Apr 3, 2024

This message doesn't necessarily mean that an update to the beatmap is available. It might also mean that the beatmap has been modified (i.e. by changing it in stable and importing from there). Or it might mean that the beatmap was intentionally maliciously modified. Or it might mean corruption. And so on and so forth.

I'm not sure how to feel about this change in that light.

What about the message @SupDos suggested? "This beatmap doesn't match the official version, please update or re-download this beatmap. Your score will not be submitted" it is more generic, i think it fits better

Co-authored-by: Walavouchey <36758269+Walavouchey@users.noreply.github.com>
@peppy peppy merged commit 2e1d63a into ppy:master Apr 4, 2024
15 of 17 checks passed
smoogipoo pushed a commit to smoogipoo/osu that referenced this pull request Apr 4, 2024
…hash-custom-message

Add custom message in the case of a `invalid beatmap_hash`
@64ArthurAraujo 64ArthurAraujo deleted the add-invalid-beatmap-hash-custom-message branch April 4, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Playing pending beatmap with an update available throws invalid beatmap_hash to user
6 participants