Revert recent storyboard optimisations #27797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoogipoo
changed the title
peppy
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 0881e7c, reversing changes made to 29a37e3.
Regressed in #27454
Supersedes/closes #27753 (see discussion in thread)
Closes #27627
I'm leaning on the side of caution instead of merging a fix to a regression that itself is a regression just in a slightly less way.
Next time this optimisation is attempted, a test case needs to be provided for the case broken in #27627 and the further case mentioned in #27753. Neither was done this time around.
Lazer handles transforms differently from stable, and that will likely need to be fixed first otherwise optimisations are more likely to further regress behaviour than not.