Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ctrl-up/down change speed modifier of mods #28071

Merged
merged 27 commits into from
May 24, 2024
Merged

Make ctrl-up/down change speed modifier of mods #28071

merged 27 commits into from
May 24, 2024

Commits on May 2, 2024

  1. Initial implementation

    Fabian van Oeffelt committed May 2, 2024
    Configuration menu
    Copy the full SHA
    f534c4a View commit details
    Browse the repository at this point in the history

  2. F1 also does not work with minus in song select, same behaviour

    Fabian van Oeffelt committed May 2, 2024
    Configuration menu
    Copy the full SHA
    5c21a03 View commit details
    Browse the repository at this point in the history

  3. Comment, make code more readable, functions are now private

    Fabian van Oeffelt committed May 2, 2024
    Configuration menu
    Copy the full SHA
    7527ddb View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into osu-lazer-speedkeys

    @Fabiano1337
    Fabiano1337 authored May 2, 2024
    Configuration menu
    Copy the full SHA
    fa0b631 View commit details
    Browse the repository at this point in the history

  5. Merge pull request #1 from Fabiano1337/osu-lazer-speedkeys 

    Osu lazer speedkeys
    @Fabiano1337
    Fabiano1337 authored May 2, 2024
    Configuration menu
    Copy the full SHA
    e737635 View commit details
    Browse the repository at this point in the history

  6. Fix Formatting

    Fabian van Oeffelt committed May 2, 2024
    Configuration menu
    Copy the full SHA
    588badf View commit details
    Browse the repository at this point in the history

  7. Fix Code Inspection

    Fabian van Oeffelt committed May 2, 2024
    Configuration menu
    Copy the full SHA
    4b5ea6b View commit details
    Browse the repository at this point in the history

Commits on May 18, 2024

  1. Change Inputkeys to Ctrl+Up/Ctrl+Down

    Fabian van Oeffelt committed May 18, 2024
    Configuration menu
    Copy the full SHA
    a12a20e View commit details
    Browse the repository at this point in the history

  2. Speedchange now also works in Modselect

    Fabian van Oeffelt committed May 18, 2024
    Configuration menu
    Copy the full SHA
    80064c4 View commit details
    Browse the repository at this point in the history

  3. Add Unit Tests

    Fabian van Oeffelt committed May 18, 2024
    Configuration menu
    Copy the full SHA
    99f30d9 View commit details
    Browse the repository at this point in the history

  4. change to single Function, 

    Nightcore now switches into Daycore, keep Adjustpitch after change
    Fabian van Oeffelt committed May 18, 2024
    Configuration menu
    Copy the full SHA
    3fdbd73 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. Change Speedchange behaviour to keep changing while holding key, Add … 

    …Toast to nofity user what just happend
    Fabian van Oeffelt committed May 21, 2024
    Configuration menu
    Copy the full SHA
    148afd1 View commit details
    Browse the repository at this point in the history

  2. Toast now only shows when speed is actually changed

    Fabian van Oeffelt committed May 21, 2024
    Configuration menu
    Copy the full SHA
    3403789 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. Basic cleanup 

    Before I gave up on attempting to fix the method.
    @peppy
    peppy committed May 22, 2024
    Configuration menu
    Copy the full SHA
    99d99ce View commit details
    Browse the repository at this point in the history

  2. Fix enum not being at end (and adjust naming)

    @peppy
    peppy committed May 22, 2024
    Configuration menu
    Copy the full SHA
    02a388c View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into lazer-speedkeys

    @peppy
    peppy committed May 22, 2024
    Configuration menu
    Copy the full SHA
    1fdebe9 View commit details
    Browse the repository at this point in the history

  4. Use null conditional rather than implicit not-null

    @peppy
    peppy committed May 22, 2024
    Configuration menu
    Copy the full SHA
    f979200 View commit details
    Browse the repository at this point in the history

  5. Add speed value to Toast

    Fabian van Oeffelt committed May 22, 2024
    Configuration menu
    Copy the full SHA
    57da422 View commit details
    Browse the repository at this point in the history

  6. Fix test not running due to floating point number inaccuacy

    Fabian van Oeffelt committed May 22, 2024
    Configuration menu
    Copy the full SHA
    abc67eb View commit details
    Browse the repository at this point in the history

  7. Improve readability

    Fabian van Oeffelt committed May 22, 2024
    Configuration menu
    Copy the full SHA
    0df6345 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. Rewrite test

    @bdach
    bdach committed May 24, 2024
    Configuration menu
    Copy the full SHA
    9045ec2 View commit details
    Browse the repository at this point in the history

  2. Rewrite implementation

    @bdach
    bdach committed May 24, 2024
    Configuration menu
    Copy the full SHA
    63406b6 View commit details
    Browse the repository at this point in the history

  3. Fix toast strings

    @bdach
    bdach committed May 24, 2024
    Configuration menu
    Copy the full SHA
    345fb60 View commit details
    Browse the repository at this point in the history

  4. Fix speed controls in mod select overlay not handling repeat

    @bdach
    bdach committed May 24, 2024
    Configuration menu
    Copy the full SHA
    8cac87e View commit details
    Browse the repository at this point in the history

  5. Actually use return value

    @bdach
    bdach committed May 24, 2024
    Configuration menu
    Copy the full SHA
    b1b2079 View commit details
    Browse the repository at this point in the history

  6. Move mod speed hotkey handler to user mod select overlay 

    The very base class is the wrong place for it because
`FreeModSelectOverlay` inherits from it, and that one has different
assumptions and rules than "user" selection. In particular, in non-user
selection, more than one rate adjust mod may be active, which breaks the
mod speed hotkey's basic assumptions.
    @bdach
    bdach committed May 24, 2024
    Configuration menu
    Copy the full SHA
    cab8cf7 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into lazer-speedkeys

    @bdach
    bdach committed May 24, 2024
    Configuration menu
    Copy the full SHA
    c800bb5 View commit details
    Browse the repository at this point in the history