-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite new song select footer and make it global #28146
Conversation
Added transitions for osu! logo now that #28147 was severly rejected: CleanShot.2024-05-11.at.18.44.21.mp4Copied mostly verbatim from |
@arflyte did you ever create motion design for the footer? i feel like i recall something somewhere at some poitn |
@frenzibyte out of curiosity is the new back button coming as part of this? it may change the animation requirements. |
No, it think that was the very first lazer design; the one that we used for the 2015? video. |
I dunno, I believe at some point last year I asked for feedback on how the footer is supposed to work with multiple screens (since the icons/buttons are to change) and you 100% made something. |
Probably referring to this? |
That's the one. Although it doesn't really give much helpful information. |
@arflyte re-ping since i don't think you follow conversations without ping each time |
@arflyte Also when defining animations for the footer, I need to know how the footer and animation would look like when the user opens the mod overlay, as there are side buttons like "Mod Customisation" and "Deselect All" as well as extra information components (BPM/CS/HP/OD/AR and difficulty multiplier) all placed on the footer in current versions of lazer: |
Hmm, I definitely need to look into the overall footer flow again. Need to double check with the other scenes and make sure the layout is consistent. Give me a day to look into this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still don't think this needs to be blocked waiting-on-design.
`TestSceneSongSelectV2Navigations` will be kept to allow for testing the overall game flow when needed. This will eventually replace `TestScenePlaySongSelect`.
SongSelectV2
screen
I've put everything I've got for the footer so far in here. Up next, I'll look into integrating the footer with the mod overlay and open a follow-up PR for that. For review, I recommend just checking the added/changed files on an IDE directly, as I've had to move things across and rename etc. |
This PR got extremely complex to the point I broke |
This PR moves the new song select footer to
OsuGame
, adds a back button, and provides a basic set of transitions for the footer and its buttons when moving between screens.I've also made a dummy
SongSelectV2
screen to pour in all the screen-level transitions for the footer, as well as moving all V2 components to a different namespace and detaching them from the oldSongSelect
etc.Preview:
CleanShot.2024-05-15.at.06.09.37.mp4
CleanShot.2024-05-15.at.06.08.59.mp4