-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct scale of taiko-glow
element to match stable
#28311
Conversation
I'm not sure where 0.8 is coming from, stable uses 0.7 as mentioned in the original PR #21459 (comment) and as I've just confirmed...
|
I'm well aware stable used 0.7, as I said I used that value in my original implementation. It clearly doesn't match visually though, which is why #27700 exists in the first place. The 0.8 value is based on the scale of the inner circle of the hit target in lazer, which I assume is what taiko-glow is supposed to surround: osu/osu.Game.Rulesets.Taiko/Skinning/Legacy/TaikoLegacyHitTarget.cs Lines 30 to 37 in d55fa42
I then double-checked this by making a visual comparison, and as you can see in the pictures this seems to check out. |
I spent half an hour and couldn't figure this out. But the change in this PR does match visually, and also matches the scale applied to the hit target: Let's just go with it for now. |
Closes #27700.
This was incorrect from from the start (see #21459). I used the values from stable in the original PR, but it turns out they don't match 1:1 (this was even brought up at the time). I did a more thorough visual check this time around to get it right.