Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move timeline toggle controls to "view" menu #28505

Merged
merged 4 commits into from
Jun 17, 2024

Conversation

bdach
Copy link
Collaborator

@bdach bdach commented Jun 17, 2024

RFC

osu_2024-06-17_10-26-02

  • Waveform toggle off replaced by 0% opacity
  • Rest migrated to the submenu depicted above
  • As a bonus, this will now be persistent across sessions by the virtue of being stored to OsuSetting / ini config

Based on this bit of reddit feedback:

I don't get why the options on the left of the timeline (waveform, ticks and bpm) are permanently there, and not in a drop-down menu in the View section? Who wants to see less of the timeline?

that I tend to agree with.

This also changes some paddings because stuff looked kind of bad after just moving the settings. There's still some badness elsewhere on the timeline (colour clashes / alignment mostly) but I kinda don't care and want to put functionality above appearance for the time being. Can be adjusted upon feedback if this isn't rejected outright.

master b42752c 03049d4
osu_2024-06-17_10-24-16 osu_2024-06-17_10-24-57 osu_2024-06-17_10-25-54
editor playfield scale gameplay playfield scale
osu_2024-06-17_10-31-38 osu_2024-06-17_10-31-34

@peppy peppy self-requested a review June 17, 2024 09:54
@peppy
Copy link
Member

peppy commented Jun 17, 2024

The paddings feel a bit tight (especially with timing changes hidden), but I think this is what people are asking for, so let's go with it.

@peppy peppy merged commit cc0ef20 into ppy:master Jun 17, 2024
8 of 11 checks passed
@bdach bdach deleted the move-timeline-toggles-elsewhere branch June 17, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants