Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show distance in pixels to previous/next object in osu! hitobject inspector #28640

Merged
merged 3 commits into from
Jun 27, 2024

Conversation

bdach
Copy link
Collaborator

@bdach bdach commented Jun 27, 2024

image

Following this bit of reddit feedback.

Implementation mostly follows stable except for the value displayed; stable would display the value relative to current slider velocity which seemed kinda unwieldy (and also annoying to implement wink, wink), so I'm not doing it. Can be re-added if users say they want it back.

peppy
peppy previously approved these changes Jun 27, 2024
@peppy
Copy link
Member

peppy commented Jun 27, 2024

Thanks to tests here, caught a pretty bad regression.

@bdach please check you're okay with my changes.

@bdach
Copy link
Collaborator Author

bdach commented Jun 27, 2024

And here I was hoping to not have to spawn yet another virtual for once...

Fair do's, changes look fine.

@peppy peppy merged commit 8598e8b into ppy:master Jun 27, 2024
15 of 17 checks passed
@bdach bdach deleted the osu-inspector-distance branch June 28, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants