-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Further timeline usability tweaks #29545
Conversation
c4b875e
to
fef56cc
Compare
I dunno how deep I want to get into the conversation here since I'm rather tired of looking at this thing over and over and probably so are you, but I'll bite, starting from general feel without looking at the code yet... Random first map I opened, I can't see any of the bpm text because it's covered by objects: Also not sure how to feel about it even on the timing screen, if I have to tilt my head 90deg to even read the value. If I were to suggest anything productive then I'd say that the value should be upright and not rotated, and maybe show to the left side of the timing point since that area is more likely to be unused. And I guess the "show timing changes" toggle in the View menu just... doesn't do anything anymore? Tick visibility seems okay I guess even after reducing the heights again, thanks to the increased spacing between pieces from the previous batch of changes (you can sorta look at the gaps to find the snap colour). |
As I touched on in discord, I don't think it needs to be completely legible. The red shows through and people will know that that means there's a timing change. Hitting F3 will make it visible, or we can add tooltips or whatever. I'm open to changes to the design proposal, what's here is what I came up with in 10 minutes.
Not sure about this, can remove it if you think that's best. |
Sure, let's just go with it and see what happens then.
If it does nothing then remove it. Could just start with removal from the menu and keep the config key around (marked as deprecated or something) just in case we decide to bring it back at some point, to not drop user settings. |
Oh I didn't actually realise I broke the functionality, intended to just remove the expanding part 😅. I'm okay to add it back and have it toggle, what do you think? I'm very neutral at this point (but less toggles better I guess?) |
If you're not fussed let's just make it work again I guess. We know already how people react to having toggles removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not gonna overthink this, let's put this to the test
Based on general feedback over the last while.
I couldn't deal with the silly control point group handling so I had to rewrite that component. Huge simplification as a result. Already split into individual commits, can split out further if required (but I think it's pretty readable).