Fix mod icons potentially showing incorrectly at daily challenge intro #29560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prefer using the beatmap's rulesets over the current user selection. Closes ppy#29559.
bdach
reviewed
Aug 22, 2024
| StarRatingDisplay starRatingDisplay; | ||
|
|
||
| IBeatmapInfo beatmap = item.Beatmap; | ||
| Ruleset ruleset = rulesets.GetRuleset(item.Beatmap.Ruleset.ShortName)?.CreateInstance() ?? Ruleset.Value.CreateInstance(); |
There was a problem hiding this comment.
Why does this still fallback to Ruleset.Value.CreateInstance()? I don't see the point, it can literally be only more wrong than the left half of this.
There was a problem hiding this comment.
Do you think the mods just shouldn't show in this case? Because I think that would be the closest alternative (we need a ruleset to show the ?? mods).
There was a problem hiding this comment.
I'd just delete the fallback here and be done with it.
There was a problem hiding this comment.
Right. I guess it's always going to be an official ruleset anyway.
bdach
approved these changes
Aug 27, 2024
smoogipoo
reviewed
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefer using the beatmap's rulesets over the current user selection.
Closes #29559.