Fix Slideraim penalty for missing slider ends #29991
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like if what is written in the OP is correct, this should go in with the current batch on changes? @ppy/osu-pp-committee |
This was referenced Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of this PR - #27303
This PR is fixing a mistake made back in 2021, when xexxar forgot that
SliderFactorneeds to be cubed before applying it to pp.The main effect of this is correct penalty for missing slider ends.
Side-effect of this is nerfing all non-FC scores, as they assumed to miss all sliderends. This is unfixable with stable scores but wouldn't be an issue with lazer scores, because you have info about exact amount of missed sliderends.