Key Counter #30
Closed
Key Counter #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… (which is now lowercase to match project styleguides)
RemieRichards
force-pushed
the
key_counter
branch
from
71ad958
to
30a8c88
Compare
…, as this kind of solution/workaround isn't wanted in the main framework.
…e the needed visuals. Borrowed nicer spritetext positions from huoyaoyuan
|
Gone through this. Code looks concise and good. Closing as we've already merged a solution. |
ILW8
added a commit
to ILW8/osu
that referenced
this pull request
Apr 13, 2024
fix kestrel server being reused when stopping and starting server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An Implementation of #29
Features:
Prerequisites:
Preview:
Turns out
KeyCounter/key-hit.png(and it's @2x) aren't necessary, since the glow is added/removed in the key up/down calls, so any visuals it was trying to achieve are covered by the glow sprite, it'll need removing from ppy:osu-resources and probably shouldn't be referenced in #29 anymore.