Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement "form" file picker #30005

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Conversation

bdach
Copy link
Collaborator

@bdach bdach commented Sep 26, 2024

Continuation of #29643.

2024-09-26.14-40-20.mp4

@peppy
Copy link
Member

peppy commented Sep 27, 2024

This is a bit annoying isn't it:

osu Game Tests 2024-09-27 at 04 27 46

Not really sure how to fix though. Seems that border is applied using different floating point values to masking.

@peppy peppy merged commit cec3f14 into ppy:master Sep 27, 2024
11 of 13 checks passed
@smoogipoo
Copy link
Contributor

This is a bit annoying isn't it:

Well, I do have this: https://github.com/smoogipoo/osu-framework/tree/shader-scissor

Maybe it'll happen at some point, but the above branch is not enough because

  • the border is being drawn by an overlay with MaskingSmoothness = 1 so it has alpha on the outer edge,
  • the content is inside a ScrollContainer with Masking = true so every masking parameter (and importantly, BorderColour) is being reset
  • so the text still bleeds through a bit and doesn't re-apply the border colour itself because it doesn't see it

Kind of a messed up scenario that needs more thought.

@bdach bdach deleted the editor/setup-screen-file-picker branch September 27, 2024 09:49
@EVAST9919

This comment was marked as outdated.

@EVAST9919

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants