Properly disable comment box on things that cannot be commented on #30058

bdach · 2024-09-30T09:10:53Z

Compare:

Closes ppy#30052. Compare: - https://github.com/ppy/osu-web/blob/83816dbe24ad2927273cba968f2fcd2694a121a9/resources/js/components/comment-editor.tsx#L54-L60 - https://github.com/ppy/osu-web/blob/83816dbe24ad2927273cba968f2fcd2694a121a9/resources/js/components/comment-editor.tsx#L47-L52

osu.Game/Overlays/Comments/CommentEditor.cs

bdach added the area:comments label Sep 30, 2024

pull-request-size bot added the size/L label Sep 30, 2024

bdach added 2 commits September 30, 2024 14:05

Isolate tests properly

155d6e5

Fix doubled-up enabled state management of commit button

74a9899

peppy reviewed Oct 1, 2024

View reviewed changes

osu.Game/Overlays/Comments/CommentEditor.cs Show resolved Hide resolved

osu.Game/Overlays/Comments/CommentEditor.cs Outdated Show resolved Hide resolved

peppy self-requested a review October 1, 2024 07:50

Specify type explicitly

8d2f251

peppy approved these changes Oct 1, 2024

View reviewed changes

peppy merged commit 598bc74 into ppy:master Oct 1, 2024
11 of 13 checks passed

bdach deleted the disabled-beatmap-comment-box branch October 1, 2024 09:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Properly disable comment box on things that cannot be commented on #30058

Properly disable comment box on things that cannot be commented on #30058

bdach commented Sep 30, 2024

Properly disable comment box on things that cannot be commented on #30058

Properly disable comment box on things that cannot be commented on #30058

Conversation

bdach commented Sep 30, 2024