Fix various distance snap grid weirdness around unsnapped objects #30062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdach
changed the title
bdach
changed the title
bdach
changed the title
bdach
force-pushed
the
distance-snap-weirdness
branch
from
0ed6ab4
to
11fc1f9
Compare
|
(sorry for force push, accidentally pushed next change to wrong branch 🙈) |
|
I feel like I tried to make this very change in the past and somehow couldn't get it working, but this seems to work as expected (and reads pretty well). 👍 |
peppy
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #30023.
I am only somewhat confident of these changes, so take with several pillars of salt.
Fix distance spacing grid displaying incorrectly for unsnapped objects with duration
As far as I can tell, this issue is specific to objects whose heads are snapped to the current beat divisor, but tails are not.
FindSnappedDistance()seems to have presumed this to be impossible, and as such just used the head's start time, which is not correct, because it will behave as if a timing point was placed at the tail (or, in other words, objects will be snapped temporally using the correct beat length, but relative to the unsnapped tail).Fix distance snap grid using wrong colour when reference object is unsnapped
This only reproduces if the unsnapped object lies on the latter half of a beat (think 700ms at beat length of 250ms). Rounding would thus shift the colours assigned up a beat.