-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add progress tooltip for ArgonSongProgressBar #30078
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppy
reviewed
Oct 3, 2024
peppy
added
the
next release
Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees!
label
Oct 4, 2024
bdach
requested changes
Oct 4, 2024
* Rewrite calculating logic * Remove useless variables
@CloneWith I rewrote every line. Please read through carefully to understand what was lacking. |
peppy
approved these changes
Oct 7, 2024
smoogipoo
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
next release
Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees!
size/S
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just referred to the beatmap editor tooltip for implementation and styles.
This is a possibly simple implementation of #30077.
Principle
Since ArgonSongProgressBar takes up all of the DrawWidth, we can use
GetContainingInputManager
for the X position of the cursor, then converting into the relative X position to the progress bar withToLocalSpace
.