Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add progress tooltip for ArgonSongProgressBar #30078

Merged
merged 8 commits into from
Oct 7, 2024

Conversation

CloneWith
Copy link
Contributor

Just referred to the beatmap editor tooltip for implementation and styles.

Tooltip style example

This is a possibly simple implementation of #30077.

Principle

Since ArgonSongProgressBar takes up all of the DrawWidth, we can use GetContainingInputManager for the X position of the cursor, then converting into the relative X position to the progress bar with ToLocalSpace.

@peppy peppy self-requested a review October 3, 2024 08:36
@peppy peppy added the next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! label Oct 4, 2024
osu.Game/Screens/Play/HUD/ArgonSongProgressBar.cs Outdated Show resolved Hide resolved
osu.Game/Screens/Play/HUD/ArgonSongProgressBar.cs Outdated Show resolved Hide resolved
* Rewrite calculating logic
* Remove useless variables
@pull-request-size pull-request-size bot added size/M and removed size/S labels Oct 4, 2024
@peppy peppy self-requested a review October 7, 2024 05:18
@pull-request-size pull-request-size bot added size/S and removed size/M labels Oct 7, 2024
@peppy
Copy link
Member

peppy commented Oct 7, 2024

@CloneWith I rewrote every line. Please read through carefully to understand what was lacking.

@peppy peppy enabled auto-merge October 7, 2024 05:33
@peppy peppy enabled auto-merge October 7, 2024 06:04
@smoogipoo smoogipoo merged commit 944f8f5 into ppy:master Oct 7, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants