ROS-melodic .debs for network_monitor_udp incomplete #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- python modules were missing (needed setup.py and `catkin_python_setup`) from .deb - python executables were missing (needed `catkin_install_python`) from .deb - python package `roslib` is deprecated; `rostime` now lives in `rospy` - compiled binaries and .launch file were missing from from .deb
bk-mtg
changed the title
v4hn
reviewed
Nov 7, 2019
This way the installed path will match the path in devel.
|
Thanks for addressing the feedback! Looks good now. |
|
Thank you! Any idea how soon we might see a release with this so as to get the updated binaries in the package system? |
|
@k-okada released the PR2 packages in the past for kinetic/melodic. |
|
Ok, done ros/rosdistro#22917
2019年11月8日(金) 15:44 Michael Görner <notifications@github.com>:
@k-okada <https://github.com/k-okada> released the PR2 packages in the
past for kinetic/melodic.
I will leave the release to him. But I would say his availability is the
only constraint on an immediate release.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3?email_source=notifications&email_token=AADYNXDJGWNLH7BWIKUVSHTQSUDDBA5CNFSM4JJ53LB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDO4XFY#issuecomment-551406487>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADYNXDCDWV4RNL52RNCIXDQSUDDBANCNFSM4JJ53LBQ>
.
--
--
◉ Kei Okada
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ROS melodic install of this package is missing most of the useful files, including the node python scripts, python libraries, and standalone binaries. Additionally, changes to the core ROS python libraries over time meant that some of the python code wouldn't run.
This PR makes the following changes, which (on my test system at least) results in usable python scripts, and generates
.debpackages that include all the desired output files:catkin_python_setupto get python libraries included in the .debcatkin_install_pythonto include python node scripts in the .debroslibis deprecated;rostimenow lives inrospy