Improve support for print media #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you rebase this @jdknight? |
The following improves the ability to print documentation themed with Furo. This includes hiding various elements (such as the mobile bar) that are not useful in printed media, as well as deals with color scheming issues for browsers who do not default to light scheme in a print media state. Signed-off-by: James Knight <james.d.knight@live.com>
jdknight
force-pushed
the
improve-print-media-support
branch
from
6e1167f
to
9f26c25
Compare
|
Thanks @jdknight! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following improves the ability to print documentation themed with Furo. This includes hiding various elements (such as the mobile bar) that are not useful in printed media, as well as deals with color scheming issues for browsers who do not default to light scheme in a print media state.
These changes also resolve an issue (observed in Chrome/Edge; Firefox is fine) where the printing preview page would think there would be tens of thousands of pages to print: