refactoring and fixes #710 #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # @param index - The current column | ||
| # @param meth - Meth (min/max); used to calculate values to be filled | ||
| # | ||
| def fill_values_if_needed(values, cell, index, meth) |
There was a problem hiding this comment.
This function is the main fix for issue #710 .
practicingruby
added a commit
that referenced
this pull request
May 28, 2014
refactoring and fixes #710
TheSmartnik
added a commit
to Silverfin-Engineering/prawn
that referenced
this pull request
Apr 15, 2022
Pots the following prs: prawnpdf#712 prawnpdf#620
TheSmartnik
added a commit
to Silverfin-Engineering/prawn
that referenced
this pull request
Apr 15, 2022
Ports the following prs: prawnpdf#712 prawnpdf#620
TheSmartnik
added a commit
to Silverfin-Engineering/prawn
that referenced
this pull request
Apr 15, 2022
Ports the following prs: prawnpdf#712 prawnpdf#620
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactoring code from cells.rb to column_width_calculator, from now on
all complex width related code is in this file.
fixed #710 be eliminating an edge case as reported under issue #710