-
-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow only valid options for commands #1467
Conversation
🦋 Changeset detectedLatest commit: ec760ab The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
description: 'Launch interactive Analyzer to inspect production bundle(s)', | ||
}, | ||
{ | ||
name: '--prerenderUrls', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We allow --prerender-urls
too right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if camel case is really something a cli should use, but seems like that's what we had before and only that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like we don't allow --prerender-urls
as of now. So technically changing this would be a breaking change.
What kind of change does this PR introduce?
This now throws error if the user passes invalid argument around
build
,create
orwatch
.Did you add tests for your changes?
Yes
Summary
Sample
Does this PR introduce a breaking change?
No.