Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer c.modules (fixes #467) #472

Merged
merged 1 commit into from
Jan 27, 2018
Merged

Prefer c.modules (fixes #467) #472

merged 1 commit into from
Jan 27, 2018

Conversation

developit
Copy link
Member

This should fix #467.

@@ -136,7 +136,7 @@ export function writeJsonStats(stats) {
function strip(stats) {
stats.modules.forEach(stripLoaderFromModuleNames);
stats.chunks.forEach(c => {
(c.mapModules!=null ? c.mapModules(Object) : c.getModules()).forEach(stripLoaderFromModuleNames);
(c.modules || (c.mapModules!=null ? c.mapModules(Object) : c.getModules())).forEach(stripLoaderFromModuleNames);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getModules() is deprecated right?

That's reason why we see that weird message when we run preact build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

preact build --json fails with TypeError: c.getModules is not a function
2 participants