This repository has been archived by the owner on Dec 16, 2021. It is now read-only.
Fix Children.toArray when passed undefined #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are cases when `this.props.chidren` is undefined and toArray was returning an array containing undefined instead of an empty array.
|
This PR shouldn't be necessary if we fix the issue in #319. |
|
Good catch. I think we might need to do an explicit check there so this doesn't also drop |
|
Done! Let me know if there is anything else. |
developit
approved these changes
Apr 5, 2017
|
I might inline this into the ternary, but TBH uglify will do that for us anyway. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are cases when
this.props.chidrenis undefined and toArray was returning an array containing undefined instead of an empty array.