This repository has been archived by the owner on Dec 16, 2021. It is now read-only.
Bind getDefaultProps to the class so statics can be read (#420) #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
developit
suggested changes
Sep 21, 2017
src/index.js
Outdated
| @@ -424,7 +424,7 @@ function createClass(obj) { | |||
| cl.defaultProps = obj.defaultProps; | |||
| } | |||
| if (obj.getDefaultProps) { | |||
| cl.defaultProps = obj.getDefaultProps(); | |||
| cl.defaultProps = obj.getDefaultProps.bind(cl)(); | |||
There was a problem hiding this comment.
Would be much cheaper to use .call() here:
cl.defaultProps = obj.getDefaultProps.call(cl);There was a problem hiding this comment.
Good call ;) I've changed it to .call.
developit
approved these changes
Dec 25, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #420