-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lazy loading with react lazy instead of preact-async-route #372
Open
jose-donato
wants to merge
2
commits into
preactjs:main
Choose a base branch
from
jose-donato:master
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+17
−16
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little wary of recommending this pattern. AsyncRoute transitions between two routes seamlessly by leveraging the fact that preact-router doesn't destroy and recreate routes if they're the same component. With
lazy()
, clicking a link immediately shows the fallback content ("loading..."), then flashes to the new route once loaded - fairly expensive.Here's a demo showing the effect:
https://codesandbox.io/s/preact-router-372-bitsq?file=/components/app.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't agree with you. I think that happens because of naive component that we are providing ("loading...") completely different from the rest of the app causing the flash effect. Correct me if i'm wrong but if we provide a component congruent with the rest of the app i don't think it would be a problem. Besides suspense/code splitting this way is now recommended by React am I wrong?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're not React and we arguably have a stronger focus on performance. Suspense isn't good for code-splitting as it will very likely lead to wasteful rendering/diffing, that will be immediately thrown out. The concept itself is flawed, which is why we don't recommend Suspense to be used in production.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marvinhagemeister if not Suspense, then what would be a good approach for code splitting with
preact-router
? If the concept is flawed then why is leaving experimental status soon? (preactjs/preact#2915) Has your stance changed?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AsyncRoutes
says it is deprecated and we should use Suspense/lazy instead...@marvinhagemeister you recommend not to use lazy/suspense...
It feels like a vicious circle, isn't it ? 😅