Fix "Improper nesting of paragraph" for span under a paragraph (#4144)

preactjs · Sep 29, 2023 · 08b07cc · 08b07cc
1 parent 0c1b93c
commit 08b07cc
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/debug/src/debug.js b/debug/src/debug.js
@@ -489,7 +489,7 @@ function isTableElement(type) {
 }
 
 const ILLEGAL_PARAGRAPH_CHILD_ELEMENTS =
-	/address|article|aside|blockquote|details|div|dl|fieldset|figcaption|figure|footer|form|h1|h2|h3|h4|h5|h6|header|hgroup|hr|main|menu|nav|ol|p|pre|search|section|table|ul/;
+	/^(address|article|aside|blockquote|details|div|dl|fieldset|figcaption|figure|footer|form|h1|h2|h3|h4|h5|h6|header|hgroup|hr|main|menu|nav|ol|p|pre|search|section|table|ul)$/;
 
 const forceUpdate = Component.prototype.forceUpdate;
 Component.prototype.forceUpdate = function (callback) {

diff --git a/debug/test/browser/debug.test.js b/debug/test/browser/debug.test.js
@@ -581,6 +581,17 @@ describe('debug', () => {
 			render(<Paragraph />, scratch);
 			expect(console.error).to.be.calledOnce;
 		});
+
+		it('should not warn for nesting span under a paragraph', () => {
+			const Paragraph = () => (
+				<p>
+					<span>Hello world</span>
+				</p>
+			);
+
+			render(<Paragraph />, scratch);
+			expect(console.error).to.not.be.called;
+		});
 	});
 
 	describe('PropTypes', () => {