Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding pointer event definitions #1102

Merged
merged 3 commits into from
May 16, 2018
Merged

Adding pointer event definitions #1102

merged 3 commits into from
May 16, 2018

Conversation

jakearchibald
Copy link
Contributor

There's a bit of a complication here. Two of the pointer event events end in Capture, so this PR also defines onGotPointerCaptureCapture for the capturing variant of this event.

Does this even work?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 7d015b9 on jakearchibald:pointer-events into b3eb9e3 on developit:master.

@developit
Copy link
Member

This is just a React API oversight. Not only is there no way to listen to an event name ending in Capture without it also being capturing, onFooCaptureCapture is required.

developit
developit approved these changes May 16, 2018
View reviewed changes
Copy link
Member

@developit developit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Despite it technically being broken, I still think we should merge this so the definitions match the DOM spec.

@developit developit merged commit a2b78ac into preactjs:master May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@developit developit developit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jakearchibald @coveralls @developit @reznord