(feat) - compat mode for preact 8 #1769
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uld probably move but we don't want to force an import of preact/compat. This would entail a 2KB increase for what could be several bytes instead
JoviDeCroock
requested review from
developit,
andrewiggins,
marvinhagemeister,
cristianbote and
ForsakenHarmony
JoviDeCroock
commented
Jul 12, 2019
developit
reviewed
Jul 25, 2019
Co-Authored-By: Jason Miller <developit@users.noreply.github.com>
Co-Authored-By: Jason Miller <developit@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in no way a definite solution yet, this will point to what would need to change in order to support our previous way of working correctly.
Small POC at 8-compat mode, this is in core for now this should probably move but we don't want to force an import of preact/compat. This would entail a 2KB increase for what could be several bytes instead.
I still have one failing test but this is more or less to show what the implications would be in supporting 8 mode, my knowledge of 8 is quite limited so I'd rather have some more eyes on this.